alwayslink=1 for reflection plugin by iancoolidge · Pull Request #11519 · grpc/grpc

iancoolidge · 2017-06-16T19:59:42Z

No description provided.

grpc-kokoro · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-06-16T19:59:43Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-06-16T20:00:06Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

nicolasnoble · 2017-06-16T20:04:22Z

This is okay to test.

grpc-testing · 2017-06-16T20:07:06Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-testing · 2017-06-16T20:09:05Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

nicolasnoble · 2017-06-17T00:25:45Z

This is ok to test.

grpc-kokoro · 2017-06-17T00:30:09Z

WARNING: You are making changes in the Bazel subdirectory. Please get explicit approval from @nicolasnoble before merging.

grpc-kokoro · 2017-06-17T00:54:02Z

[trickle] No significant performance differences

grpc-kokoro · 2017-06-17T01:08:20Z

[microbenchmarks] No significant performance differences

iancoolidge · 2017-06-28T04:42:54Z

I rebased this PR.

grpc-kokoro · 2017-06-28T04:50:09Z

WARNING: You are making changes in the Bazel subdirectory. Please get explicit approval from @nicolasnoble before merging.

iancoolidge · 2017-06-28T04:52:51Z

Split this to two CLs. One to propagate alwayslink, and one to enable it for the reflection plugin (improve granularity)

grpc-kokoro · 2017-06-28T05:00:09Z

WARNING: You are making changes in the Bazel subdirectory. Please get explicit approval from @nicolasnoble before merging.

grpc-kokoro · 2017-06-28T05:15:36Z

[trickle] No significant performance differences

ncteisen · 2017-06-28T05:51:46Z

Linking in @y-zeng since he is handling import. I think this change is blocking some internal things (is that correct @iancoolidge?), so getting it in sooner would be nice

iancoolidge · 2017-06-28T06:43:11Z

We were told to commit this here first, This fixes grpc_cli

…

On Tue, Jun 27, 2017 at 10:52 PM, Noah Eisen ***@***.***> wrote: Linking in @y-zeng <https://github.com/y-zeng> since he is handling import. I *think* this change is blocking some internal things (is that correct @iancoolidge <https://github.com/iancoolidge>?), so getting it in sooner would be nice — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11519 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5u5FdfRXQ15yRN8KFRtPJveBKa3iubks5sIeoAgaJpZM4N838u> .

y-zeng · 2017-07-12T21:30:51Z

Jenkins: test this please

grpc-testing · 2017-07-12T21:30:51Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-kokoro · 2017-07-12T22:17:19Z

[trickle] No significant performance differences

grpc-kokoro · 2017-07-12T22:34:49Z

[microbenchmarks] No significant performance differences

grpc-kokoro · 2017-07-12T23:08:53Z

WARNING: You are making changes in the Bazel subdirectory. Please get explicit approval from @nicolasnoble before merging.

y-zeng · 2017-07-13T22:34:48Z

bazel/grpc_build_system.bzl

Missing a ,

D'oh! Thanks. Done.

The reflection plugin uses a static initializer to enable itself, but no one depends on its symbols, so it gets optimized out. Set alwayslink in the reflection plugin to fix that.

grpc-testing · 2017-07-17T04:39:06Z

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

iancoolidge · 2017-07-17T18:24:56Z

I pushed a new version of the branch that fixes that missing comma,
is there anything else I need to do??>

grpc-kokoro · 2017-07-17T22:29:09Z

[microbenchmarks] No significant performance differences

grpc-kokoro · 2017-07-17T22:47:43Z

[trickle] No significant performance differences

y-zeng · 2017-07-18T23:34:24Z

Jenkins: test this please

grpc-kokoro · 2017-07-19T00:36:35Z

[trickle] No significant performance differences

grpc-kokoro · 2017-07-19T00:52:35Z

[microbenchmarks] No significant performance differences

iancoolidge · 2017-07-19T17:30:02Z

Is this ready to merge?

dgquintas · 2017-07-19T18:30:07Z

Issues: #11109

googlebot added the cla: yes label Jun 16, 2017

iancoolidge force-pushed the devel-reflection branch from 4d3443c to 01a6fe8 Compare June 28, 2017 04:42

iancoolidge force-pushed the devel-reflection branch from 01a6fe8 to faf3aea Compare June 28, 2017 04:43

iancoolidge force-pushed the devel-reflection branch from faf3aea to 8d08d8a Compare June 28, 2017 04:51

ncteisen requested a review from y-zeng June 28, 2017 05:48

y-zeng suggested changes Jul 13, 2017

View reviewed changes

iancoolidge added 2 commits July 13, 2017 15:42

Propagate alwayslink in the grpc_cc_library build rule template.

6b08cf4

alwayslink=1 for reflection plugin

1321341

The reflection plugin uses a static initializer to enable itself, but no one depends on its symbols, so it gets optimized out. Set alwayslink in the reflection plugin to fix that.

iancoolidge requested review from a11r, ctiller and dgquintas as code owners July 13, 2017 22:42

iancoolidge force-pushed the devel-reflection branch from 8d08d8a to 1321341 Compare July 13, 2017 22:42

ctiller requested review from nicolasnoble and removed request for nicolasnoble July 17, 2017 18:26

y-zeng approved these changes Jul 18, 2017

View reviewed changes

dgquintas approved these changes Jul 19, 2017

View reviewed changes

dgquintas merged commit 6bc22ff into grpc:master Jul 19, 2017

lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019

Conversation

iancoolidge commented Jun 16, 2017

Uh oh!

grpc-kokoro commented Jun 16, 2017

Uh oh!

grpc-testing commented Jun 16, 2017

Uh oh!

grpc-testing commented Jun 16, 2017

Uh oh!

grpc-testing commented Jun 16, 2017

Uh oh!

grpc-testing commented Jun 16, 2017

Uh oh!

grpc-testing commented Jun 16, 2017

Uh oh!

grpc-testing commented Jun 16, 2017

Uh oh!

grpc-kokoro commented Jun 16, 2017

Uh oh!

grpc-kokoro commented Jun 16, 2017

Uh oh!

grpc-kokoro commented Jun 16, 2017

Uh oh!

grpc-testing commented Jun 16, 2017

Uh oh!

grpc-kokoro commented Jun 16, 2017

Uh oh!

grpc-kokoro commented Jun 16, 2017

Uh oh!

grpc-testing commented Jun 16, 2017

Uh oh!

nicolasnoble commented Jun 16, 2017

Uh oh!

grpc-testing commented Jun 16, 2017

Uh oh!

grpc-testing commented Jun 16, 2017

Uh oh!

nicolasnoble commented Jun 17, 2017

Uh oh!

grpc-kokoro commented Jun 17, 2017

Uh oh!

grpc-kokoro commented Jun 17, 2017

Uh oh!

grpc-kokoro commented Jun 17, 2017

Uh oh!

iancoolidge commented Jun 28, 2017

Uh oh!

grpc-kokoro commented Jun 28, 2017

Uh oh!

iancoolidge commented Jun 28, 2017

Uh oh!

grpc-kokoro commented Jun 28, 2017

Uh oh!

grpc-kokoro commented Jun 28, 2017

Uh oh!

ncteisen commented Jun 28, 2017

Uh oh!

iancoolidge commented Jun 28, 2017 via email

Uh oh!

y-zeng commented Jul 12, 2017

Uh oh!

grpc-testing commented Jul 12, 2017

Uh oh!

grpc-kokoro commented Jul 12, 2017

Uh oh!

grpc-kokoro commented Jul 12, 2017

Uh oh!

grpc-kokoro commented Jul 12, 2017

Uh oh!

y-zeng Jul 13, 2017

Choose a reason for hiding this comment

Uh oh!

iancoolidge Jul 13, 2017

Choose a reason for hiding this comment

Uh oh!

grpc-testing commented Jul 17, 2017

Uh oh!

iancoolidge commented Jul 17, 2017

Uh oh!

grpc-kokoro commented Jul 17, 2017