-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Find a way to have configurable in depth logging #257
Copy link
Copy link
Closed
Labels
area/coredisposition/help wantedMaintainers do not have enough resources to allocate to this at the moment. Help is appreciated!Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated!
Description
We have gpr_log(GPR_DEBUG), but this needs to evaluate all arguments even if the log is thrown away, which makes it impractical for the critical path.
We've also made some use of #defines previously to enable tracing, but this is rapidly becoming unmanageable.
I'm a little in favor of having a GRPC_DEBUG environment variable (maybe with an equivalent public api) that initializes some flags that we can test in carefully selected parts of the code... And perhaps one big #define that makes all of those flags statically zero to optimize away even the checks should that prove necessary.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/coredisposition/help wantedMaintainers do not have enough resources to allocate to this at the moment. Help is appreciated!Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated!