Skip to content

Reading of options from env variables is broken in setup.py (e.g. BUILD_WITH_BORING_SSL_ASM) #24498

@nanonyme

Description

@nanonyme

What version of gRPC and what language are you using?

1.32.0

What operating system (Linux, Windows,...) and version?

Linux

What runtime / compiler are you using (e.g. python version or version of gcc)

GCC 10

What did you do?

Noticed that there's no possible value that can be passed through as BUILD_WITH_BORING_SSL_ASM that will disable boringssl https://github.com/grpc/grpc/blob/master/setup.py#L109-L110

Since there's no int() conversion of input (or similar), all possible inputs will be regarded as true.

What did you expect to see?

It's possible to disable boringssl asm when using system ssl

What did you see instead?

It's not possible to disable boringssl asm when using system ssl

Anything else we should know about your project / environment?

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions