PHP getConnectivityState() tests flaking #19335
Description
I'm seeing what looks like a flake in the PHP tests in #19042. I've only seen two failures (details below): one was the initial failure reported on the PR, and the second was when I re-ran the test to see if it was a flake. When I re-ran it a second time, it passed.
The kokoro test history does not show this failure anywhere other than the PR, which seems to imply that it is related to the PR. However, @ZhouyihaiDing was not able to reproduce the problem with the PR. Furthermore, I don't think anything in the PR should affect these tests, and we have equivalent tests in C++ that do work properly with the PR. So I'm not really sure what to think.
I don't remember seeing this failure prior to merging in changes from master (the force-push from 774d8b3 to 7767fbe), so if there is a problem in the PR, it's probably somewhere in that diff.
In the interest of making forward progress, I'm going to merge my PR, but I'm filing this bug so that we figure out what's actually causing the test failures and get it fixed before the next release. This is not actually P0 at the moment, but I'm using the release-blocker label to ensure that we address this before the next release.
Here are the details on the two test failures:
There was 1 failure:
1) EndToEndTest::testGetConnectivityState
Failed asserting that false is true.
/Volumes/BuildData/tmpfs/src/github/grpc/workspace_php_macos_opt_native/src/php/tests/unit_tests/EndToEndTest.php:512
FAILURES!
Tests: 131, Assertions: 311, Failures: 1.
There was 1 failure:
1) EndToEndTest::testWatchConnectivityStateSuccess
Failed asserting that false is true.
/Volumes/BuildData/tmpfs/src/github/grpc/workspace_php_macos_opt_native/src/php/tests/unit_tests/EndToEndTest.php:531
FAILURES!
Tests: 131, Assertions: 309, Failures: 1.