fix: add Sendable conformance to DispatchQueueExecutor on Linux#1814
fix: add Sendable conformance to DispatchQueueExecutor on Linux#1814groue merged 1 commit intogroue:developmentfrom
Sendable conformance to DispatchQueueExecutor on Linux#1814Conversation
|
Hello @alephao, Thank you for restoring the Linux build! However, I do not feel comfortable in the long term. Adding an Since I suppose one or several related issues have been opened in the Swift repository. I'd appreciate if you'd link to them here in a comment. I'll feel more comfortable merging the PR after that. (Please tell me if my question is not clear) |
|
Hi @groue thanks for the quick response. Found a few related issues, they are not related to Related issues:
|
|
Wow, that's perfect. Thank you very much for this investigation and for opening swiftlang/swift-corelibs-libdispatch#910 👍 I can now see that the feedback is almost inexistent, but the rationale for this PR is strong. |
|
Merged! 👍 |
|
Oh, and thank you very much for restoring the Linux build 🙏 |
|
⛵ Shipped in v7.7.0! |
I've been using GRDB for a while on Linux, but recently I started getting build failures due to
DispatchQueueExecutornot conforming toSendable. This change fixes it by conditionally setting@unchecked Sendablewhen on Linux.https://github.com/swiftlang/swift-corelibs-libdispatch/blob/0bb6c10fa556722654917b4a18ba2dc39b18392a/src/swift/Block.swift#L16
developmentbranch.make smokeTestterminal command runs without failure.