Skip to content

Add Sendable conformance to DatabasePreUpdateEvent.Kind, matching DatabaseEvent.Kind#1773

Merged
groue merged 2 commits intogroue:developmentfrom
Jason-Abbott:development
Jun 1, 2025
Merged

Add Sendable conformance to DatabasePreUpdateEvent.Kind, matching DatabaseEvent.Kind#1773
groue merged 2 commits intogroue:developmentfrom
Jason-Abbott:development

Conversation

@Jason-Abbott
Copy link
Copy Markdown
Contributor

@Jason-Abbott Jason-Abbott commented May 30, 2025

Add Sendable conformance to DatabasePreUpdateEvent.Kind, matching DatabaseEvent.Kind

(xctest is crashing with error 14493 🤷🏻‍♂️ when I try to smoke test so I’m not able to check that box, below)

Pull Request Checklist

  • CONTRIBUTING: You have read https://github.com/groue/GRDB.swift/blob/master/CONTRIBUTING.md
  • BRANCH: This pull request is submitted against the development branch.
  • DOCUMENTATION: Inline documentation has been updated.
  • DOCUMENTATION: README.md or another dedicated guide has been updated.
  • TESTS: Changes are tested.
  • TESTS: The make smokeTest terminal command runs without failure.

@groue
Copy link
Copy Markdown
Owner

groue commented Jun 1, 2025

Thank you @Jason-Abbott :)

I'll try to reproduce the crash when I'm back to my computer.

@groue groue merged commit 79a41dc into groue:development Jun 1, 2025
8 checks passed
@groue
Copy link
Copy Markdown
Owner

groue commented Jun 1, 2025

WTF, GitHub has destroyed the development branch after the merge. I'll fix this later.

@Jason-Abbott
Copy link
Copy Markdown
Contributor Author

Jason-Abbott commented Jun 1, 2025

WTF, GitHub has destroyed the development branch after the merge. I'll fix this later.

Ah crap, I hope that wasn’t me. I didn’t notice the update fork function here only applies to the currently active branch so I had to update my development branch after I’d committed the change.

I’d be glad to re-submit if you want to revert this.

@groue
Copy link
Copy Markdown
Owner

groue commented Jun 1, 2025

:) Don't worry. I really think this is a bug with GitHub (pretty rare, isn't it?) that will be easy to fix: the merge commit is 79a41dc.

@groue
Copy link
Copy Markdown
Owner

groue commented Jun 2, 2025

Whatever happened has solved itself: the development branch is there, with your PR merged. I don't quite remember what I have seen now. Case solved, and thank you for this welcome contribution, @Jason-Abbott :-)

@groue
Copy link
Copy Markdown
Owner

groue commented Jul 20, 2025

Hi @Jason-Abbott. I'm sorry for this long delay. Your changes have been shipped in v7.6.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jason-Abbott @groue