Merged
Conversation
6cc601e to
e220eb9
Compare
Contributor
|
A nested array is inefficient, and requires significantly more memory allocations. # gem install benchmark-memory
require 'benchmark/memory'
Benchmark.memory do |x|
Pair = Struct.new(:a, :b)
x.report('two arrays') do
array_1 = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
array_2 = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
end
x.report('hash') do
hash = { 1 => 1, 2 => 2, 3 => 3, 4 => 4, 5 => 5, 6 => 6, 7 => 7, 8 => 8, 9 => 9, 10 => 10 }
end
x.report('nested array') do
array = [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [7, 7], [8, 8], [9, 9], [10, 10]]
end
x.report('struct') do
array = [Pair.new(1, 1), Pair.new(2, 2), Pair.new(3, 3), Pair.new(4, 4), Pair.new(5, 5),
Pair.new(6, 6), Pair.new(7, 7), Pair.new(8, 8), Pair.new(9, 9), Pair.new(10, 10)]
end
x.compare!
end |
Owner
Author
|
hehe nice! :D I think it's not as easy to benchmark since we are doing lots of array expansions too, |
Owner
Author
|
I did not find a clean way of using less arrays. ... keeping it clean/simple until someone else has a nice idea or need for this 🤷 |
Owner
Author
|
1.24.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup to Add :finish_in_order option #339