Adding "property" attribute for scripts parameter in execute mojo#316
Adding "property" attribute for scripts parameter in execute mojo#316keeganwitt merged 4 commits intogroovy:masterfrom
Conversation
|
Thanks for the PR! I changed the variable name since other properties didn't include a prefix. I'm not sure if that was the best choice to have made (I think that dates back to the original GMaven days), but thought it was better to be consistent. I also added a couple additional properties I thought might be useful. |
|
Thanks. But yes - shorter version is nice to use and consistent with parameter name. |
|
I had the same thought about collisions, but wasn't seeing prefixes in official Maven plugins. It appears they don't make any specific recommendations about that. What I meant by consistency was with the other parameter properties that already exist. I'd like them to be all prefixed, or none of them. |
Without "property" attribute in "Parameter" calling execute mojo from command line is not working.
For example for call:
mvn org.codehaus.gmavenplus:gmavenplus-plugin:4.0.2-SNAPSHOT:execute -Dscripts="src\main\groovy\FooScript.groovy"I got:
The parameters 'scripts' for goal org.codehaus.gmavenplus:gmavenplus-plugin:4.0.2-SNAPSHOT:execute are missing or invalidWhen "property" attribute is added, execute mojo is working, eg.:
mvn org.codehaus.gmavenplus:gmavenplus-plugin:4.0.2-SNAPSHOT:execute -Dgp.exec.scripts="src\main\groovy\FooScript.groovy"