Skip to content

Update documentation to make it easier for firstcomers#1310

Merged
lfoppiano merged 34 commits into
masterfrom
improvement/better-simpler-documentation
Aug 29, 2025
Merged

Update documentation to make it easier for firstcomers#1310
lfoppiano merged 34 commits into
masterfrom
improvement/better-simpler-documentation

Conversation

@lfoppiano

@lfoppiano lfoppiano commented Jul 7, 2025

Copy link
Copy Markdown
Member

This PR aims to make the documentation less scary for python and young developers 🐉

Goals:

  1. Provide an easy "getting started"
  2. Allow people to try on the cloud in advance
  3. For local deployment prioritise Docker over the native installation

@coveralls

coveralls commented Jul 7, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 40.266%. remained the same
when pulling 94446e1 on improvement/better-simpler-documentation
into 9cd6fb9 on master.

@lfoppiano lfoppiano changed the title Update documentation Update documentation to make it easier to start Jul 8, 2025
@lfoppiano

lfoppiano commented Jul 16, 2025

Copy link
Copy Markdown
Member Author

One comment is to streamline the docker image naming, which is pretty confusing.

We could use

  1. grobid/grobid:{version}-{full|crf}
  2. or we could use lfoppiano/grobid:{version}-{full|crf} which would be easier for me to maintain :-)

@lfoppiano lfoppiano requested a review from Copilot August 24, 2025 15:07

This comment was marked as outdated.

@lfoppiano lfoppiano requested a review from Copilot August 24, 2025 19:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve the documentation user experience by making it less intimidating for Python and new developers. The changes focus on providing better getting started guidance, cloud deployment options, and prioritizing Docker over native installation.

  • Modernizes the documentation theme from ReadTheDocs to Material Design for better user experience
  • Creates a comprehensive "Getting Started" guide that prioritizes cloud and Docker deployment options
  • Reorganizes navigation structure to put essential information first and deprecate advanced features

Reviewed Changes

Copilot reviewed 23 out of 29 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
readthedocs.yml Updates build environment to Ubuntu 24.04
mkdocs.yml Switches theme to Material Design with dark/light mode and reorganizes navigation
doc/requirements.txt Adds mkdocs-material dependency
doc/readthedocs.js Adds JavaScript for ReadTheDocs integration with Material theme
doc/overrides/main.html Adds template override for ReadTheDocs API integration
doc/getting_started.md Creates new comprehensive getting started guide
doc/index.md Updates main page structure and navigation links
Multiple training docs Converts note blocks to Material Design admonitions
Various service docs Updates references and adds error handling documentation
Readme.md Updates demo link and adds getting started tip
GitHub workflows Updates Docker image tagging conventions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread doc/readthedocs.js
Comment on lines +1 to +7
document.addEventListener("DOMContentLoaded", function(event) {
// Trigger Read the Docs' search addon instead of Material MkDocs default
document.querySelector(".md-search__input").addEventListener("focus", (e) => {
const event = new CustomEvent("readthedocs-search-show");
document.dispatchEvent(event);
});
});

Copilot AI Aug 24, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable name collision: The parameter event in the outer function shadows the locally created event CustomEvent. This could cause confusion and potential issues. Consider renaming one of the variables.

Copilot uses AI. Check for mistakes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@lfoppiano lfoppiano requested a review from Copilot August 25, 2025 10:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@lfoppiano lfoppiano changed the title Update documentation to make it easier to start Update documentation to make it easier for firstcomer Aug 29, 2025
@lfoppiano lfoppiano changed the title Update documentation to make it easier for firstcomer Update documentation to make it easier for firstcomers Aug 29, 2025
@lfoppiano lfoppiano merged commit 9b51b7a into master Aug 29, 2025
13 checks passed
@lfoppiano lfoppiano deleted the improvement/better-simpler-documentation branch August 29, 2025 07:27
@seang096 seang096 mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants