return configuration processing parameters in response header#1274
Merged
return configuration processing parameters in response header#1274
Conversation
Member
Author
|
The git revision is not always available, for example when grobid is run in intellij idea calling directly the main class, we've return <appInfo>
<application version="unknown" ident="GROBID" when="2025-04-11T07:46+0000">
<desc>GROBID - A machine learning software for extracting information from scholarly documents</desc>
<label type="revision">unknown</label>
<label type="parameters">startPage=-1, endPage=-1, consolidateCitations=0, consolidateHeader=0, consolidateFunders=0, includeRawAffiliations=false, includeRawCitations=false, includeRawCopyrights=false, generateTeiIds=false, generateTeiCoordinates=[], flavor=null</label>
<ref target="https://github.com/kermitt2/grobid"/>
</application>
</appInfo>When we run with <appInfo>
<application version="0.8.2-SNAPSHOT" ident="GROBID" when="2025-04-11T07:14+0000">
<desc>GROBID - A machine learning software for extracting information from scholarly documents</desc>
<label type="revision">812314141</label>
<desc type="parameters">startPage=-1, endPage=-1, consolidateCitations=0, consolidateHeader=0, consolidateFunders=0, includeRawAffiliations=false, includeRawCitations=false, includeRawCopyrights=false, generateTeiIds=false, generateTeiCoordinates=[], flavor=null</desc>
<ref target="https://github.com/kermitt2/grobid"/>
</application>
</appInfo>However the revision is not working when running |
…ible with the TEI guidelines
61d5b3b to
4381cb8
Compare
4381cb8 to
3070362
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to add part of the configuration parameters that have been sent to the server for processing (see comment in #1253), in the response header, information such as
sentenceSegmentation? True/False, model flavor, coordinates, etc..The proposal for the header would be
@kermitt2 Would this be an acceptable approach?
@laurentromary any comment or suggestions on TEI side?
UPDATE: I've removed
@revisionand moved underlabel @type=revisionto be compliant with the TEI guidelines.