Fix code scanning alert no. 41: Resolving XML external entity in user-controlled data#1205
Merged
Fix code scanning alert no. 41: Resolving XML external entity in user-controlled data#1205
Conversation
…-controlled data Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…sion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
lfoppiano
commented
Dec 11, 2024
Member
Author
lfoppiano
left a comment
There was a problem hiding this comment.
This changes look good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/kermitt2/grobid/security/code-scanning/41
To fix the problem, we need to ensure that the XML parser is fully secured against XXE attacks. This involves:
SAXParserFactoryis configured to disallow DTDs.XMLReaderis configured to disallow external entities.EntityResolverthat returns an empty string for any external entity.Suggested fixes powered by Copilot Autofix. Review carefully before merging.