Skip to content

Add includeRawCopyrights in the UI#1181

Merged
lfoppiano merged 4 commits intogrobidOrg:masterfrom
annelhote:master
Oct 30, 2024
Merged

Add includeRawCopyrights in the UI#1181
lfoppiano merged 4 commits intogrobidOrg:masterfrom
annelhote:master

Conversation

@annelhote
Copy link
Copy Markdown
Contributor

@annelhote annelhote commented Oct 11, 2024

No description provided.

lfoppiano
lfoppiano requested changes Oct 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lfoppiano lfoppiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @annelhote and thanks for this PR. I've noticed a problem in the XML output that is not related to this PR, that should be included.

The licence/copyright additional XML tags added in output make the full document invalid because here is a <p type="raw" that is closed with a </note>.

Should be fixed here and here.

Thank you! 😄

@lfoppiano lfoppiano added this to the 0.8.2 milestone Oct 21, 2024
@annelhote annelhote requested a review from lfoppiano October 29, 2024 10:22
@annelhote
Copy link
Copy Markdown
Contributor Author

annelhote commented Oct 29, 2024

Thank you so much for your help 🙏 .
Sorry about the mess in the commits, I am not (yet) used to work trough PRs but happy to learn. I'll try to remember to create dedicated branch for each PR next time.

lfoppiano
lfoppiano approved these changes Oct 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lfoppiano lfoppiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @annelhote , thanks for the update. The change looks good, before merging, however, I would like to validate with @kermitt2 if the outer tag should be a p or a note.

This is the current version

<p type="raw">Copyright © 2024 Laetitia et al. This is an openaccess article distributed under the terms of the Creative Commons Attribution 4.0 International license.</p>

@kermitt2
Copy link
Copy Markdown
Collaborator

kermitt2 commented Oct 29, 2024 •
edited
Loading

Hello, it should appear in a <p> according to https://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-availability.htmlhttps://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-availability.html
Thanks !

@lfoppiano
Copy link
Copy Markdown
Member

lfoppiano commented Oct 29, 2024

Thanks!

About the attribute @type? It does not seems to be expected for a <p> do we still want to keep it? https://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-p.html 🤔

@kermitt2
Copy link
Copy Markdown
Collaborator

kermitt2 commented Oct 29, 2024

In TEI, @typecan be added to any elements. In this case we identify the source of these copyright information similarly as the other "raw" strings.

@lfoppiano lfoppiano merged commit 3d098ea into grobidOrg:master Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lfoppiano lfoppiano lfoppiano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.8.2

Development

Successfully merging this pull request may close these issues.

3 participants

@annelhote @kermitt2 @lfoppiano