Skip to content

fix notes identification#1124

Merged
lfoppiano merged 2 commits intomasterfrom
bugfix/notes-same-label
Jun 12, 2024
Merged

fix notes identification#1124
lfoppiano merged 2 commits intomasterfrom
bugfix/notes-same-label

Conversation

@lfoppiano
Copy link
Copy Markdown
Member

@lfoppiano lfoppiano commented Jun 10, 2024

More details are in #1113.

TLDR:

  • avoid collecting the same position in the text when the note label is the same. So for example if we have This note1, and this note2, but back to the first note1, we would collect twice the offset of the first 1 label.
  • update the labels2notes so that we use the identifier instead.
  • fix a NPE when the note tokenization are empty, the processShort return a null, so we skip such note

…ntifier to fetch the specific notes from the map
@lfoppiano lfoppiano added this to the 0.8.1 milestone Jun 10, 2024
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 40.791% (+0.004%) from 40.787%
when pulling 2f9e211 on bugfix/notes-same-label
into 694f0ed on master.

@lfoppiano lfoppiano marked this pull request as ready for review June 10, 2024 04:08
@lfoppiano lfoppiano requested a review from kermitt2 June 10, 2024 04:08
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 40.792% (+0.005%) from 40.787%
when pulling a472cb1 on bugfix/notes-same-label
into 694f0ed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants