Add missing sentence segmentation in funding and acknowledgement #1106
Merged
Add missing sentence segmentation in funding and acknowledgement #1106
Conversation
added 11 commits
April 12, 2024 09:28
added 10 commits
May 1, 2024 17:07
…egmentation and the reference markers
added 7 commits
May 4, 2024 08:09
…aracter-based when the same tokens occur subsequently
…aracter-based when the same tokens occur subsequently and the annotation is composed by a single token
added 4 commits
May 5, 2024 20:57
…om the funding-acknowledgment
…d object for annotations with xml nodes
Member
Author
|
I did run all documents from PLOS, PMC and biorxiv over this, I've checked manually differences for a sample from each corpus. I also checked manually the merging of the coordinates for certain problematic documents that were causing problems in the past. It seems that everyhting looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement fixes the way the
funding-acknowledgmentparser handles an already formatted statement and preserve their existing elements (references, sentences). #1090This PR fixes the following problems:
The initial solution proposed in the #1090 discussion, to re-apply a sentence segmentation that act on the transformed TEI structure was not applicable because it was not possible to re-generate the sentence coordinates as the TEI-XML elements do not have anymore layout-token information.
NOTE: this should be merged after #1096