Skip to content

Fix missing coordinates in paragraphs continuation #1076

Merged
kermitt2 merged 2 commits intomasterfrom
bugfix/paragraph-coords
Jan 21, 2024
Merged

Fix missing coordinates in paragraphs continuation #1076
kermitt2 merged 2 commits intomasterfrom
bugfix/paragraph-coords

Conversation

@lfoppiano
Copy link
Copy Markdown
Member

@lfoppiano lfoppiano commented Jan 18, 2024 •
edited
Loading

When the paragraph continues after interruption (e.g., reference callout), the coordinates are lost:

image

This PR solves this issue.
image

This PR also adds a small modification in the frontend so that the paragraph coordinates are extracted if "add coordinates" is selected and "segment sentence" is not selected.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 18, 2024

Coverage Status

coverage: 39.906% (+0.01%) from 39.892%
when pulling 0d7913d on bugfix/paragraph-coords
into cbc77d5 on master.

@lfoppiano lfoppiano requested a review from kermitt2 January 18, 2024 22:39
@kermitt2
Copy link
Copy Markdown
Collaborator

kermitt2 commented Jan 21, 2024

I didn't see the problem in the previous PR, sorry !

@kermitt2 kermitt2 merged commit e14ce33 into master Jan 21, 2024
@lfoppiano lfoppiano deleted the bugfix/paragraph-coords branch January 22, 2024 01:37
@lfoppiano
Copy link
Copy Markdown
Member Author

lfoppiano commented Jan 22, 2024 •
edited
Loading

Neither did I when I was developing it. The structure viewer app (https://structure-vision.streamlit.app/) is quite helpful in validating the stream order of PDF extraction.

@lfoppiano lfoppiano added this to the 0.8.1 milestone Jun 9, 2024
@Darrshan-Sankar
Copy link
Copy Markdown

Darrshan-Sankar commented Sep 16, 2024 •
edited
Loading

Still there are few paragraphs un-annotated it seems. I checked in a PDF. Any fixes?

@lfoppiano
Copy link
Copy Markdown
Member Author

lfoppiano commented Sep 16, 2024

Oulx you please share an example?

@Darrshan-Sankar
Copy link
Copy Markdown

Darrshan-Sankar commented Sep 16, 2024

Please check with these articles:

https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=10510434 ------> Article page no:9
https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=10042417 --------> Article page no:8

And similarly many more articles

@lfoppiano lfoppiano mentioned this pull request Sep 16, 2024
Open
@lfoppiano
Copy link
Copy Markdown
Member Author

lfoppiano commented Sep 16, 2024

Those issues are not related with this PR. Here the issue is that part of the text is misclassified as figure.

I've referenced your comment in a separate issue. This will likely be solved, or, at least, mitigated by #963 (WIP).

@Darrshan-Sankar
Copy link
Copy Markdown

Darrshan-Sankar commented Sep 16, 2024

@lfoppiano Thanks looking forward for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kermitt2 kermitt2 Awaiting requested review from kermitt2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.8.1

Development

Successfully merging this pull request may close these issues.

4 participants

@lfoppiano @coveralls @kermitt2 @Darrshan-Sankar