Conversation
Member
Author
|
With this PR is possible to run a different version than 3.8 (the jep shipped with grobid requires python 3.8) and relay on conda for the environment. Here what I did for running DL models natively using a conda environment:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for python virtual environments for JDK 11+. Should be merged after #921.
It supports venv and conda.
Update: I've noticed I'm not able to run grobid natively on linux without installing the python dependencies as a system dependencies. Usually I've correlate the use of this PR with the removal of the JEP library under the grobid-home, in favour of the JEP installed in the python library / virtual environment.
We could improve the detection of the python version.