Skip to content

Publication date potentially corrected from the consolidation service seems to be lost in a limbo  #760

@lfoppiano

Description

@lfoppiano

Related to #759.
I tried to solve the problem by enabling the consolidation, however, the correct publication date was not retrieved correctly.

The BiblioItem object from the consolidation service had:

  • publicationDate = null
  • normalisedPublicationDate with the correct value

(I wonder if this is the correct behaviour)

however, in the BiblioItem, after the correct(...) method is invoked, the normalisedPublication date is overridden with the first raw publication date:

// normalization of dates
                if (resHeader != null) {
                    if (resHeader.getPublicationDate() != null) {
                        List<Date> dates = parsers.getDateParser().processing(resHeader.getPublicationDate());
                        // most basic heuristic, we take the first date - to be
                        // revised...
                        if (dates != null) {
                            if (dates.size() > 0) {
                                resHeader.setNormalizedPublicationDate(dates.get(0));
                            }
                        }
                    }

This will inevitably lose the good normalised date from the consolidation service. I'm not sure what is the correct behaviour, I supply this issue mostly for information as I assume there many different use cases 😉

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugFrom Hemiptera and especially its suborder Heteroptera

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions