Skip to content

Magic Shelf filtering based on Metadata Presence > Hardcover ID is broken #65

@andrewtwelch

Description

@andrewtwelch

What Went Wrong?

Trying to filter using this option doesn't work correctly.

The initial load of book data doesn't include these IDs, and the filtering is purely client side, so there's no way to use this filtering option until the SPA is now aware of the ID existing (saving the metadata for a book, even with no changes, does this. Opening the edit screen alone doesn't appear to cover this.).

This issue would expand to any metadata field that isn't returned by the /api/v1/books endpoint.

How Can We Reproduce This?

  1. Refresh your page (if you haven't freshly opened the app)
  2. Filter based on Metadata Presence > Has not > Hardcover ID.
  3. See that books are shown even if they have a Hardcover ID.
  4. Edit a book's metadata and save, even without making any changes.
  5. See the book disappear from the magic shelf.
  6. Refresh the page fully.
  7. See that same book show up again.

What Should Have Happened?

Filtering should function correctly.

Screenshots or Error Messages (Optional)

No response

Any Ideas on How to Fix This? (Optional)

Either have the books endpoint return all details, or have the magic shelf filtering be server side instead of client side.

Your Setup

Booklore v2.2.1

Before Submitting

  • I've searched existing issues and confirmed this bug hasn't been reported yet

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-reproductionA bug has been reported, but it has not been confirmed or reproduced by a contributor

    Type

    No fields configured for Bug.

    Projects

    Status
    Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions