Skip to content

chore(frontend): enforce zero build warnings + fix frontend build warnings #420

@zachyale

Description

@zachyale

What would you like to improve?

The frontend currently enforces zero lint warnings/errors, but build warnings were still allowed. We should align all thresholds to zero and remove the remaining known build warnings so CI reliably blocks regressions

What's the current friction?

Current state:

  • LINT_WARNING_THRESHOLD=0
  • LINT_ERROR_THRESHOLD=0
  • BUILD_WARNING_THRESHOLD=24

Known build warnings:

  1. ExternalDocLinkComponent is imported but unused in GlobalPreferencesComponent.
  2. CommonJS warning for @stomp/stompjs used by @stomp/rx-stomp.

What would make this better?

  1. Remove unused ExternalDocLinkComponent import/registration from GlobalPreferencesComponent
  2. Add @stomp/stompjs to allowedCommonJsDependencies in Angular build config
  3. Set BUILD_WARNING_THRESHOLD=0 in .github/workflows/angular-lint-threshold.yml

Anything else? (Optional)

No response

Before Submitting

  • I've searched existing issues and confirmed this enhancement hasn't been requested yet

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No fields configured for Chore.

    Projects

    Status
    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions