Skip to content

Library Health Check pings even if unauthenticated #378

@NamLe029

Description

@NamLe029

What went wrong?

Library Health Check is pinged regardless of if user is authenticated or not. This healthcheck is an authenticated endpoint, which reject the request if it does not include credentials.

This even occurs in /login route, which can cause infinite crash loop on frontend as it's configured to re-route to /login when receiving 401 responses. The reason why it's not crash looping till this day is that the /api/v1/libraries/health handler responds with "403 Forbidden" instead of "401 Unauthorized" for unauthenticated request.

How can we reproduce this?

  1. Log out
  2. Access /login endpoint

What should have happened?

Should not ping if unauthenticated

Your setup

Grimmory v2.3.0

Before submitting

  • I've searched existing issues and confirmed this bug hasn't been reported yet

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No fields configured for Bug.

    Projects

    Status
    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions