fix(cbx-reader): add GIF and BMP to supported image extensions by graypawn · Pull Request #230 · grimmory-tools/grimmory

graypawn · 2026-03-27T02:27:36Z

Description

GIF and BMP images inside CBX archives are not displayed in the web reader. This PR adds support for these formats.

Linked Issue: Fixes #165

Changes

Added .gif and .bmp to SUPPORTED_IMAGE_EXTENSIONS in CbxReaderService.java

Test Output

Environment: Docker gradle:9.3.1-jdk25-alpine (same image as project Dockerfile)

> Task :test
3483 tests, 0 failures, 15 ignored
Duration: 11m 7.38s

BUILD SUCCESSFUL in 20m 34s
6 actionable tasks: 6 executed

Verification

Deployed the build on my server and tested with the following CBZ file:

format_test.cbz — 8 pages, one per format (JPG, JPEG, PNG, WebP, AVIF, HEIC, GIF, BMP)
format_test.zip

Summary by CodeRabbit

New Features
- Added support for GIF and BMP image formats in comic book archives. The application now recognizes these formats as valid page images when reading archive files, improving compatibility and expanding the range of image formats that can be used in comic book publications.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai · 2026-03-27T02:27:49Z

📝 Walkthrough

Walkthrough

The CbxReaderService now supports GIF and BMP image formats in CBX archives by extending the SUPPORTED_IMAGE_EXTENSIONS list, enabling these formats to be recognized as valid page images alongside the existing JPG, JPEG, PNG, WebP, AVIF, and HEIC formats.

Changes

Cohort / File(s)	Summary
Image Format Support `booklore-api/src/main/java/org/booklore/service/reader/CbxReaderService.java`	Extended `SUPPORTED_IMAGE_EXTENSIONS` array to include `.gif` and `.bmp` formats, allowing these image types to be recognized and included in CBX archive page lists.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

backend, enhancement

Poem

🐰 A carrot-colored gift for CBX files so rare,
GIF and BMP now dance with elegant flair,
No longer lost in the archive's deep lair,
Every page format gets equal care! 📚✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title follows conventional commit format with 'fix' type and clear description of the change.
Description check	✅ Passed	The PR description follows the template with all required sections: Description, Linked Issue, and Changes. Additional test output and verification sections provide comprehensive context.
Linked Issues check	✅ Passed	The code changes directly address issue `#165` by adding .gif and .bmp to SUPPORTED_IMAGE_EXTENSIONS, enabling these formats to be displayed in CBX archives.
Out of Scope Changes check	✅ Passed	All changes are strictly scoped to the issue: only the SUPPORTED_IMAGE_EXTENSIONS constant was modified in CbxReaderService, with no additional unrelated changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

✨ Simplify code

Create PR with simplified code

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@booklore-api/src/main/java/org/booklore/service/reader/CbxReaderService.java`:
- Line 42: The controller currently hardcodes "image/jpeg" when streaming CBX
pages; update the BookMediaController method that serves CBX pages (the handler
around lines 65-76) to derive the actual MIME type from the selected archive
entry (the CBX page entry you obtain via
CbxReaderService/SUPPORTED_IMAGE_EXTENSIONS) and call
response.setContentType(mimeType) before writing the page bytes to the output
stream; ensure the MIME string comes from the archive entry's metadata or by
mapping the entry's file extension to a proper MIME (e.g., via a small helper or
existing mapping) and use that value instead of the fixed "image/jpeg".

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9c338a48-8902-4e68-b3f8-0da15cd5ea6d

📥 Commits

Reviewing files that changed from the base of the PR and between aff1ecb and 0a0c10e.

📒 Files selected for processing (1)

booklore-api/src/main/java/org/booklore/service/reader/CbxReaderService.java

📜 Review details

🧰 Additional context used

📓 Path-based instructions (1)

booklore-api/src/**/*.java

📄 CodeRabbit inference engine (AGENTS.md)

booklore-api/src/**/*.java: Use 4-space indentation in Java files and match surrounding Java style
Prefer constructor injection via Lombok patterns already used in the codebase. Do not introduce @Autowired field injection
Use MapStruct for entity/DTO mapping

Files:

booklore-api/src/main/java/org/booklore/service/reader/CbxReaderService.java

balazs-szucs

Thank you for investigating this, and raising a PR!

…ory-tools#230) Co-authored-by: de.banker <hub9ray@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Co-authored-by: de.banker <hub9ray@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

fix(cbx-reader): add GIF and BMP to supported image extensions

0a0c10e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

coderabbitai Bot added backend enhancement labels Mar 27, 2026

coderabbitai Bot reviewed Mar 27, 2026

View reviewed changes

Comment thread booklore-api/src/main/java/org/booklore/service/reader/CbxReaderService.java

balazs-szucs approved these changes Mar 27, 2026

View reviewed changes

balazs-szucs merged commit be22f55 into grimmory-tools:develop Mar 27, 2026
1 check passed

zachyale pushed a commit to zachyale/grimmory that referenced this pull request Apr 17, 2026

fix(cbx-reader): add GIF and BMP to supported image extensions (grimm…

9257d19

…ory-tools#230) Co-authored-by: de.banker <hub9ray@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

zachyale pushed a commit to zachyale/grimmory that referenced this pull request Apr 17, 2026

fix(cbx-reader): add GIF and BMP to supported image extensions (grimm…

aa5305f

…ory-tools#230) Co-authored-by: de.banker <hub9ray@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

zachyale pushed a commit that referenced this pull request Apr 17, 2026

fix(cbx-reader): add GIF and BMP to supported image extensions (#230)

48942d0

Co-authored-by: de.banker <hub9ray@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

zachyale pushed a commit that referenced this pull request Apr 22, 2026

fix(cbx-reader): add GIF and BMP to supported image extensions (#230)

74c7ad5

Co-authored-by: de.banker <hub9ray@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

This was referenced May 8, 2026

Migrate ImageIO-based image pipeline to vips-ffm #1222

Open

Cover replacement writes WebP image but retains JPEG filename/media type #1252

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(cbx-reader): add GIF and BMP to supported image extensions#230

fix(cbx-reader): add GIF and BMP to supported image extensions#230
balazs-szucs merged 1 commit into
grimmory-tools:developfrom
graypawn:fix/cbx-reader-gif-bmp-support

graypawn commented Mar 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 27, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

balazs-szucs left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

graypawn commented Mar 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Test Output

Verification

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

balazs-szucs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

graypawn commented Mar 27, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 27, 2026 •

edited

Loading