Skip to content

fix(pwa): swap PWA icons to light theme#1122

Merged
imnotjames merged 1 commit into
grimmory-tools:developfrom
imnotjames:fix/789/pwa-icon-variant
May 5, 2026
Merged

fix(pwa): swap PWA icons to light theme#1122
imnotjames merged 1 commit into
grimmory-tools:developfrom
imnotjames:fix/789/pwa-icon-variant

Conversation

@imnotjames

@imnotjames imnotjames commented May 5, 2026

Copy link
Copy Markdown
Contributor

Description

switches the PWA icon SVG and all sized icons to be the light icon variant so it displays safely on both light & dark background for iOS.

Linked Issue

fixes #789

Changes

  • updates SVG icon for PWA app to use color #ff2126
  • updates PNG icon for PWA app

Manual Testing Steps

  1. open site in iOS and create a PWA
  2. open site in MacOS safari and create a PWA
  3. open site in Android and create a PWA

Screenshots (Optional)

iOS Light

image

iOS Dark
image

Android
image

Additional Context (Optional)

Generated with a script because I got lazy.

SIZES="72 96 128 144 152 192 384 512"
for SIZE in $SIZES; do
        echo "CREATING $SIZE"
        rsvg-convert -h "$SIZE" -w "$SIZE" icon.svg > "icon-${SIZE}x${SIZE}.png"
        pngcrush -brute -ow "icon-${SIZE}x${SIZE}.png"
done

AI Disclosure

None

Checklist

  • This PR links and implements an accepted issue.
  • This PR is a single focused change.
  • There are new or updated tests validating this change.
  • I ran just ui check and just api check.
  • I have added screenshots if there were any UI changes.
  • I have disclosed any AI usage as per the organization AI Policy above.
  • I understand all of my submitted changes.

@coderabbitai

coderabbitai Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (9)
  • frontend/public/icons/icon-128x128.png is excluded by !**/*.png, !**/*.png
  • frontend/public/icons/icon-144x144.png is excluded by !**/*.png, !**/*.png
  • frontend/public/icons/icon-152x152.png is excluded by !**/*.png, !**/*.png
  • frontend/public/icons/icon-192x192.png is excluded by !**/*.png, !**/*.png
  • frontend/public/icons/icon-384x384.png is excluded by !**/*.png, !**/*.png
  • frontend/public/icons/icon-512x512.png is excluded by !**/*.png, !**/*.png
  • frontend/public/icons/icon-72x72.png is excluded by !**/*.png, !**/*.png
  • frontend/public/icons/icon-96x96.png is excluded by !**/*.png, !**/*.png
  • frontend/public/icons/icon.svg is excluded by !**/*.svg, !**/*.svg

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3def4a89-6ddb-477a-bb81-86ecef478429

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@imnotjames imnotjames marked this pull request as ready for review May 5, 2026 04:12
@imnotjames imnotjames merged commit 2fcbb5c into grimmory-tools:develop May 5, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PWA icon uses dark variant in light mode instead of light variant

2 participants