-
Notifications
You must be signed in to change notification settings - Fork 25
Readonly Rootcap #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Readonly Rootcap #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers a few changes to Gridsync's "Recovery Key" subsystem in order to reduce the likelihood of multiple devices writing to the same Tahoe-LAFS directories at the same time (thereby, hopefully helping to avoid data-loss situations stemming from uncoordinated writers). This is achieved by a rather rudimentary "capability rotation" scheme:
In addition to the above changes, this PR increments the the "base directory" inside the rootcap from "v0" to "v1", signalling both a period of stability and a(n unfortunate) break from past compatibility guarantees. Attempting to import/restore from an old Recovery Key will display an error message to users, informing them that their old Recovery Key is no longer compatible with the current version of the software.