Convert gridsync/tahoe.py to async def
#526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The were exclusively yielding `Deferred.fromCoroutine(...)` so this is a pure simplification.
crwood
approved these changes
Aug 9, 2022
Member
crwood
left a comment
There was a problem hiding this comment.
This all looks good to me -- thank you so much!
(And thank you, especially, for getting rid of some of those Mocks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #523
Please note
test_tahoe_stop_locked. I'm not sure if this kind of global reactor interaction is correct with pytest_twisted, and even if so if it is the preferred style in GridSync's tests. However, I'm also not sure what else to do there.The commits are almost all self-contained changesets that address one function from
tahoe.pycompletely throughout the codebase, in case that helps with review.