-
Notifications
You must be signed in to change notification settings - Fork 25
Support privatestorageio-zkapauthz-v2 replicate/recover functionality
#499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds (preliminary?) support for ZKAPAuthorizer's new ZKAP Database Replication / Recovery feature, completing most -- but not all -- of the tasks outlined in this comment. The exceptions are:
This will be completed in the near future as part of addressing #449 (which may result in further breaking changes)
End-to-end/integration tests for ZKAP issuance/redemption/replication/recovery are notably lacking as a result of the complexities involved in spinning up a PaymentServer across (non-NixOS) platforms. Members of the PrivateStorage team are in the currently in the process of ameliorating this a) by developing separate tooling to automate the issuance/redemption of ZKAPs (among other things) and b) refactoring of some parts of the Gridsync codebase better facilitate headless end-to-end testing and automation.