Fix intermittently-failing Supervisor "restart" test #481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Supervisortesttest_supervisor_restarts_process_when_killedhas been failing intermittently on Windows, for some time -- perhaps because 3 seconds isn't enough time for a process to be killed on GitHub Actions' Windows runners, or perhaps because filesystem operations are extra slow on GHA, or perhaps because Windows re-uses PIDs more eagerly than other operating systems... In any case, it happens frequently enough to be a source of developer-frustration and, Windows-specific issues aside, it isn't a very good test anyway:This PR improves the intermittently-failing test by verifying (and awaiting on, for a more generous 10 seconds) the running and not-running states of the supervised process (by PID) in order to determine whether the Supervisor "restart" functionality is working correctly. The result of these changes is much closer to the intended behavior of the component being tested; it avoids the filesystem, accommodates for slower systems, and will waste less time on actually-faster ones.