-
Notifications
You must be signed in to change notification settings - Fork 25
Some type annotations and some export key refactoring #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know what the deal with QThread is but it's more work to use than Twisted's thread API and when you make a mistake, it SIGABRTs your whole process instead of giving you an exception, so let's not use it if we don't have to.
Without this, mypy (and/or pyqt5-stubs?) thinks ZKAPBarChartView's inherited `chart()` method will always/only return a plain `QChart` (and will throw an "attr-defined" error -- "'QChart' has no attribute 'update_chart'"). Using a custom getter here avoids this confusion: `ZKAPBarChartView.get_chart` will always/only return a `ZKAPBarChart`.
As with the previous commit, using this custom/type-annotated getter informs mypy that we are always/only expecting `View` to use a `Model` (from gridsync/gui/model.py) for its model and not some other, broader type that's missing the methods/attributes we want to type-check.
…ome-more-type-annotations.2
This avoids a TypeError from pynacl that disrupts key export.
b089dc3 to
1653f17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.