Skip to content

Conversation

@crwood
Copy link
Member

@crwood crwood commented May 21, 2022

This PR makes some minor adjustments to desktop.notify with the aim of providing working fallback mechanisms for desktop environments that don't support traditional desktop notifications:

  • On Linux-like systems, actually catch and handle exceptions raised by txbus calls in the event that, e.g., the host operating system lacks DBus (these exceptions were previously uncaught due to missing yield statement...)
  • Show a popup message via QSystemTray.showMessage iff the systray actually supports messages
  • Fall back to logging the message, if all else fails

@crwood crwood merged commit e464741 into master May 21, 2022
@crwood crwood deleted the desktop-notification-fallbacks branch May 21, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants