Allow adding Magic-Folders for empty directories #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #457 disallowed adding empty folders in order to compensate for some limitations with the Magic-Folder "status" API. Those limitations have since been resolved (specifically, by the addition of `last-scan` and `last-poll` fields), making it possible to make determinations about the sync status of empty folders. Accordingly, this change reverts #457, allowing empty Magic-Folders to be added again (without those folders appearing to be stuck in a "Loading..." state).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #457 disallowed adding empty folders in order to compensate for some
limitations with the Magic-Folder "status" API. Those limitations have
since been resolved (specifically, by the addition of
last-scanandlast-pollfields), making it possible to make determinations aboutthe sync status of empty folders. Accordingly, this change reverts #457,
allowing empty Magic-Folders to be added again (without those folders
appearing to be stuck in a "Loading..." state).