Update PyQt5 and add PyQt5-stubs #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates PyQt5 and it's associated libraries to a newer version (from version 5.15.1 to 5.15.6) and adds the
PyQt5-stubspackage to thelinttox testenv, effectively allowing mypy's type checking to now work against (most?) PyQt5 objects. Prior to this change, mypy's "has no attribute" error was being suppressed globally to account for the missing stubs (which resulted in legitimate attribute errors going uncaught -- and in mypy's type checks, more generally, being less useful to this project).As a consequence of this change -- or, more specifically, due to this Qt bug -- support for Debian 10/"Buster"/oldstable will be dropped (but may be reinstated if/when PyQt5 ships the newly-open-sourced Qt 5.15.3 LTS).