Allow values in config.txt to be overridden via environment variables
#466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows any/all configuration values normally declared in
gridsync/resources/config.txtto be optionally overridden by means of settingGRIDSYNC_-prefixed environment variables. Environment variable names must follow formGRIDSYNC_SECTION_OPTIONin order for the corresponding value to override the value of the appropriate section and option ofconfig.txt-- for example, setting an environment variable ofGRIDSYNC_DEBUG_LOG_MAXLEN=512is equivalent to having the following entry inconfig.txt:In addition, this PR also slightly modifies the behavior of populating the UI such that, if a "default" grid connection is declared (e.g., via
GRIDSYNC_CONNECTION_DEFAULT=demo-grid) that grid will also always be selected/displayed first by default (thereby it somewhat easier to switch between connections in the event that multi-grid support has also been disabled).Closes #465