Prevent/handle TypeError in Tahoe.ls
#464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles the TypeError that would previously raise (and go uncaught) when
Tahoe.lswas unable to read JSON from the Tahoe-LAFS web API (for example, due to connection problems). With these changes,Tahoe.lswill return aNonetype in such situations that can be handled (more) appropriately by higher-level callers: in the case of attempting (and failing) to list/compare magic-folder backups during a periodic MagicFolderMonitor check, a warning will be logged; in the case of attempting (and failing) to restore a magic-folder backup that cannot be read, a slightly more friendly error message will be propagated to the user.