-
Notifications
You must be signed in to change notification settings - Fork 25
Improve magic-folder "status" parsing #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how the information represented in the "Status" column is determined and improves upon some adjacent functionality related to how Gridsync parses/handles JSON messages from the Magic-Folder status API. These changes include:
last-scan/last-pollin order to determine more quickly when a folder can be considered "up to date". (Previously, Gridsync had to wait until upload/download operations were observed and completed before making such a determination reliably, as there was no way to tell whether folders weren't syncing because they were already up-to-date or because Magic-Folder had not yet completed a scan/poll).gridsync.gui.model,gridsync.gui.status, andgridsync.gui.systray).