Make leaving magic-folders (and removing folder backups) idempotent #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe this is a little more clear
Thereby allowing folders to be re-added after being removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437
Also fixes two adjacent/related issues discovered along the way:
MagicFolder.magic_folders). Previously, this state was only being updated whenMagicFolderMonitor.do_checkwas being called -- resulting in a temporary situation in which the "Folders" view's context menu could display actions that were invalid for the given folder type (for example, offering the "stop syncing" action for a folder that was no longer active/syncing).MagicFolder.remote_magic_folders). Likewise, this state was also only being updated whenMagicFolderMonitor.do_checkwas being called -- resulting in a temporary situation in which it would not be possible to immeditaley re-add a folder that was recently removed until after another action was taken.