Drop Python 2 packaging #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to see if they work...
This will need to be regenerated later for Python 3
Otherwise, on python3, this raises "TypeError: '<' not supported between instances of 'str' and 'tuple'"
Otherwise, on python3, this raises "builtins.UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 0: invalid start byte"
Because this will import PyQt5 -- which requires a DISPLAY or xvfb-run
This was referenced Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the python2-based
frozen-tahoeandmagic-folder"make" targets and associated PyInstaller configurations in favor of a more unified, python3-only approach. Tooling for managing dependency-pins/hashes has also been updated similarly (with Gridsync more-or-less copying thepip-compile-based workflow from the Magic-Folder project) in hopes of simplifying future maintenance.In addition, a new
pyinstaller-mergedmake target has been provided (whichmake pyinstalleris now "aliased" to by default) that leverages PyInstaller's multipackage bundles feature, drastically reducing the filesize of the final package (between ~18% to ~26%, depending on the platform). Users who, for whatever reason, wish to build Gridsync packages the "old" way (i.e., by creating Tahoe-LAFS and Magic-Folder PyInstaller bundles separately and copying them into the Gridsync one) may still do so via themake pyinstaller-separatetarget.