-
Notifications
You must be signed in to change notification settings - Fork 25
Improve Recovery Key creation #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thereby recording that a Recovery Key has been successfully exported.
Past user testing/feedback has suggested that the terms "import" and "export" are confusing or unclear in the context of handling Recovery Keys. Accordingly, replace "export" with "create" (or "save" in the context of writing to disk) and "import" with "restore from".
See previous commit
As per the previous two commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #405 and provides some additional smaller enhancements intended to improve the safety and user-experience pertaining to creating Recovery Keys -- especially for ZKAPAuthorizer-enabled storage grids. Among them:
PasswordDialogto give users clearer or more explicit instructions about how/whether to proceed. (Previously, continuing was triggered by an Enter/Return key press -- while cancelling was triggered by Esc -- which wasn't very discoverable.)