Skip to content

Conversation

@crwood
Copy link
Member

@crwood crwood commented Nov 28, 2021

This PR removes most -- but not all -- of the remaining code pertaining to the now-removed tahoe magic-folder feature (which has since been superseded by the new standalone "Magic-Folder" application) and fixes/improves a number of small/miscellaneous things along the way, such as:

  • Fixing/restoring the total "Stored:" indicator in the status panel to work with new Magic-Folder
  • Fixing/restoring the "expected expiry" indicator (used on ZKAPAuthorizer-enabled grids) to work with new Magic-Folder
  • Improving the "overall" status indicator to update immediately (instead of periodically, according to a timer) for new Magic-Folder
  • Updating log-filters to conceal additional secrets (like author name, sign/verify keys) used by new Magic-Folder
  • Fixing a potential crash condition caused by attempting to calculate file-sizes for files that were recently moved or removed from an active magic-folder
  • Switching to new Magic-Folder's tahoe-objects endpoint for calculating ZKAP/token costs for (new) magic-folders
  • Removing all sorts of hacks that were previously necessary to work around various (old) tahoe magic-folder bugs/limitations (and thereby hopefully restoring little bit of sanity for at least one developer...)

Thereby guarding against TypeErrors when performing operations that
expect ints -- such as `humanize.naturalsize`
This functionality is now effectively provided by the combination of
`RootcapManager` and the `MagicFolderMonitor.compare_backups` check.
@crwood crwood merged commit b5f82ab into master Nov 28, 2021
@crwood crwood deleted the 408.remove-old-magic-folder-code branch November 28, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants