Magic-Folder upload progress-indicators #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The Windows environment on GitHub Actions appears to have been recently changed/updated in a way that's now breaking PyInstaller. Since this PR passing without issue on Buildbot, however -- and since we don't currently depend on GHA for deploying such binaries -- I'm going to merge this PR anyway (and will investigate the GHA/Windows issue separately...). EDIT: FWIW, the PyInstaller breakage is due to GHA updating to Python 3.9.8, which, apparently, lacks an embedded manifest file. See pyinstaller/pyinstaller#6367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some parsing/monitoring routines for tracking individual file Magic-Folder upload/download operations, subsequently enabling progress-indicators for Magic-Folder upload operations (displayed in the form of a text-based percentage (e.g., "Syncing (75%)") in the "Status" column for each folder) and reinstating desktop notifications for newly-updated files. Due to current limitations with both Tahoe-LAFS and the Magic-Folder status API, however, this sync-progress value is presently calculated from the number of operations queued against the number of operations completed only; it does not take into account the number of bytes transferred/remaining (but may in the future, if/when Tahoe-LAFS and Magic-Folder provide such information). Accordingly, this indicator should not be relied upon to, e.g., estimate the amount of time remaining until a given folder has finished synchronizing (but is, at least, better than nothing...).
Note, also, that at the time of writing, the progress indicator only tracks upload operations; progress indicators for download operations are currently broken as a result of tahoe-lafs/magic-folder#589.