Skip to content

Voucher redemption fixes #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crwood merged 14 commits into from
Oct 3, 2021
Merged

Voucher redemption fixes #385

crwood merged 14 commits into from
Oct 3, 2021

Conversation

@crwood
Copy link
Member

@crwood crwood commented Sep 27, 2021 •
edited
Loading

This PR adds a few small improvements to the voucher/token redemption process in order to address #381 -- namely:

  • Verify that vouchers were correctly added to ZKAPAuthorizer before launching a payment form via the user's browser
  • Display user-facing errors (instead of merely logging them) in the event that a) adding/verifying a voucher or b) launching the user's browser fails for any reason (and capture tracebacks behind a "Show Details..." button in the error dialog)
  • Display ephemeral status messages throughout the various stages of the redemption process ("Adding voucher...", "Verifying voucher...", "Browser window launched; please proceed to payment", etc.)

crwood added 14 commits September 25, 2021 17:27
@crwood
Double-check/verify that added vouchers were added
469547c
@crwood
Display add_voucher errors to the user
da76838
@crwood
Ensure voucher was added before launching browser
43abd9d
@crwood
Include traceback under "Show Details..."
9b301a9
@crwood
Flat is better than nested
c23c378
@crwood
Show user-facing error if webbrower.open() fails
99badb3
@crwood
Show ephemeral status messages during redemption
6aa8e96
@crwood
Suppress mypy warning regarding reactor.callLater
3f249b3
@crwood
Remove unused import
600e8bd
@crwood
Clear old status messages when redemption suceeds
8522880
@crwood
Update ZKAPAuthorizer to b08aace
3013772
@crwood
Only include "redeemed" tokens in total count
0a9fdee 
This way, the total reflects the actual number of tokens available to
ZKAPAuthorizer (and omits merely *potential* amounts from vouchers
that may, in actuality, never be paid/redeemed)
@crwood
Update docstring
0c42580
@crwood
Merge branch 'master' into 381.voucher-redemption-fixes
ce7a0d8
@crwood crwood marked this pull request as ready for review October 3, 2021 14:52
@crwood crwood merged commit 3aefd59 into master Oct 3, 2021
@crwood crwood deleted the 381.voucher-redemption-fixes branch October 3, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crwood