Update pyqtchart nix expression. #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @tomprince. I can confirm this builds for me and I can run the resulting GridSync. I see a GUI window before it gives up from not being able to find magic-folder and exits. I think that means this is a good change. I have another branch elsewhere where I'm working on adding magic-folder to the Nix packaging and this will help that along a bunch. This also looks like a better job than any of the Nix/Qt packaging work I've done so far. |
Contributor
|
@crwood I'd be happy to see this merged. |
Member
|
Apologies for letting this slip under the radar; merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #378.
I've not actually run this, but it does build.
cc: @exarkun