Container builds #329
Merged
Container builds #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to make diffing/comparing two AppImages easier
To assist with reproducible/deterministic builds
This allows the pyrsistent C extension build reproducibly
until podman stabilizes
Member
Author
|
GitHub Actions' |
This was referenced Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for building Gridsync inside a CentOS 7-based Docker/OCI container (via the
make in-containermake target), thereby facilitating the building and distribution of backward-compatible Gridsync binaries on GNU/Linux hosts (and addressing #328)In addition, this PR includes a some minor updates to the build-process which result in Gridsync AppImages building reproducibly/deterministically on the same host; running
make clean in-containermultiple times in a row on the same machine will result in bit-for-bit identical outputs (given the same inputs/source-code). Some variation has been observed across some hosts, however (for example, between older and newer versions of Ubuntu), suggesting that some sources of indeterminacy still remain, but investigating -- and addressing -- these is outside the scope of this PR.