Fix status indicators when offline #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And thereby allow the "disconnected" signal to actually be emitted.
Since these are functionally equivalent for the user; "Scanning" is just waiting one more Monitor cycle to ensure that another syncing process hasn't started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #300, ensuring that no magic-folders will be marked as "Up to date" in the UI unless their corresponding
tahoeclient is sufficiently connected to the storage grid (as determined by whether it has connected to enough nodes to satisfy theshares.happythreshold and has successfully completed a remote scan/crawl of the rootcap). The distinction between "Syncing" and "Scanning" has also been removed from the UI, since there was no functional difference between them from the user's perspective. Lastly, the total number of "connected" and "known" storage nodes -- along with the total amount of storage space available -- will now always be visible via the status label's tooltip (instead of via the now-removed "globe" button -- which served no other function).Some additional -- and very minor -- code-quality improvements have also been included, in particular, constants (
LOADING,SYNCING,UP_TO_DATE, etc.) are now used to more clearly represent folder-states instead of bareints (0,1,2, etc.).