Reduce AppImage filesize #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the PyInstaller-generated 'gridsync' binary expects/requires some libs -- including libQt5* -- to be available in the same directory.
Otherwise, linuxdeploy will re-copy the just-removed libraries
Since it turns out that '--output=appimage' isn't necessary and appimagetool needs to get called manually after deduplication anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
make_appimagescript to remove the seemingly-superfluous secondary copies of various libraries inserted by thelinuxdeployutility (replacing them instead with symlinks to the originals) and repack the resultant deduplicated AppDir with the vanilla/upstreamappimagetool(in order to avoid re-insertion). On a CentOS7 buildbot-worker run, this shaved a whopping 43.6 MB off of the final AppImage file with no discernible issues or downsides (testing Debian 9, Debian 10, Fedora 29, and Fedora 30).Closes #251