Add support for macOS Mojave's "dark mode" #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows "dark mode" to be enabled for the macOS .app bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for macOS 10.14/Mojave's "dark mode", by explicitly disabling the
NSRequiresAquaSystemAppearanceapp bundle setting (via "Info.plist") and fixing the most egregious color/stylesheet-related issues that prevented dark mode from being considered "supported" earlier.There are additional optimizations that could be made here still (for example, by providing both "light" and "dark" variants of various image files/resources and loading the appropriate variant to further improve contrast as needed) but, for now, Mojave's dark mode should at least be usable.
Closes #213