194.qt5.12 upgrade #196
Merged
194.qt5.12 upgrade #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt 5.12 is only compatible with macOS 10.12 or higher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Gridsync's PyQt5 requirement to version 5.12 but also changes various build-related scripts/configs to downgrade PyQt5 to a known working/compatible version in the event that the host is running an older operating system (including, specifically, Debian 8, Ubuntu 14.04, and macOS 10.11 -- all of which are now unsupported upstream). In addition,
tox.iniand the Makefile have been cleaned up somewhat to make platform-specific builds less convoluted; users can now simply runmaketo get a working PyInstaller-generated binary using the last-supported Qt5 version for that system (instead of, specifying, e.g.,make macos-legacyfor older versions of macOS). As another convenience,make testwill now run the test suite, conditionally wrapping thetoxcall underxvfb-runon non-macOS *nix systems (rather than dealing withtox.inis fairly limiting "platform" tags to achieve the same result).