178.systray menu fallback #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the application must be open in order to open this menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #178 by decoupling the system tray menu from the system tray icon itself: in the event that the application is being run under a desktop environment that does not support a system tray (such as the latest vanilla version of GNOME), a gear/cog button will appear in the bottom-right corner of the status panel which, when clicked, will display the menu that was previously inaccessible.
For users of desktop environments that do support a system tray (including macOS, Windows, Ubuntu and, seemingly, every other commonly-used Linux distro/environment), this changes nothing: the menu will continue to be accessible from the system tray, as expected.