169.tor proxy bypass #171
Merged
169.tor proxy bypass #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thereby preventing any early/unwanted connections to the relay server
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the behavior of the
gridsync.wormhole_.WormholeQObject/wrapper to delay creating the underlyingwormholeobject (from the magic-wormhole library) untilWormhole.connect()is called. This fixes the situation in which Gridsync/magic-wormhole would needlessly open an idle connection to the relay/rendezvous server during initialization (despite not actually using that connection -- thankfully -- in the event that the user enables Tor).Fixes #169
Big thanks to @abmoka for noticing this!