Folder removal improvements #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a weird issue whereby Config.get() was somehow caching the value of the magic_folder "enabled" option of tahoe.cfg -- even after the `tahoe magic-folder leave` command removed the section/option from the file..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the fixes relating to folder-creation and linking from #160, this PR provides a few minor improvements relating to folder-removal and unlinking, specifically:
tahoe restartafter successfully leaving one or more magic-folders (in order to compensate for Tahoe-LAFS' "Zombie Dragon" issue)RawConfigParserwas erroneously caching old values fromtahoe.cfgeven aftertahoe magic-folder leavehad modified it causing folders to appear to be stuck in a "Loading..." state after restarting