Always use bundled tahoe executable if frozen #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the "tahoe" module's
select_executable()logic to always use the bundled Tahoe-LAFS executable in the event that the user is running a frozen/binary build, thereby preventing problems stemming from another, potentially broken or outdated Tahoe-LAFS installation on the user's PATH interfering with the operation of the application. As a bonus, the application startup time should be shortened by a second or two (as a result of no longer having to probe the othertahoeinstances on the PATH).Users still wishing to use their own tahoe installs with Gridsync can still do so by running the application from source or in a python virtual environment and/or by replacing the PyInstaller bundle in the
Tahoe-LAFSdirectory with one their own.