152.innosetup6 #153
Merged
152.innosetup6 #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This directive is only available in Inno Setup version 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #152 by updating the Inno Setup installer and associated build scripts to no longer prompt the user for an administrator password, defaulting to an install location of
%LocalAppData%\Programs\Gridsync. If Inno Setup version 6 is available on the host/build system, however, the resultant installer will instead take advantage of the newPrivilegesRequiredOverridesAlloweddirective and, when executed, prompt the user to either "Install for me only (recommended)" or "Install for all users" (and prompt for an administrator password).